Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpins dependencies #418

Merged
merged 1 commit into from
Apr 10, 2024
Merged

unpins dependencies #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/418.housekeeping
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Unpins multiple dependencies.
39 changes: 37 additions & 2 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ cvprac = { version = "^1.2.2", optional = true }
dnspython = { version = "^2.1.0", optional = true }
nautobot-device-lifecycle-mgmt = { version = "^2.0.0", optional = true }
packaging = ">=21.3, <24"
prometheus-client = "~0.17.1"
prometheus-client = "^0.17.1"
ijson = { version = ">=2.5.1", optional = true }
ipfabric = { version = "~6.0.9", optional = true }
ipfabric-diagrams = { version = "~6.0.2", optional = true }
Expand All @@ -50,7 +50,7 @@ pytz = { version = ">=2019.3", optional = true }
requests = { version = ">=2.21.0", optional = true }
requests-oauthlib = { version = ">=1.3.0", optional = true }
six = { version = ">=1.13.0", optional = true }
drf-spectacular = "0.26.3"
drf-spectacular = "^0.26.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the app even need to care about the drf-spectacular version, given that it receives this dependency from nautobot core?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point, same should go for the prometheus_client honestly. I will review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce here 8ce6d6f by @snaselj - any idea why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be probably reverted, don't remember exact reason other than there was a generic advice to use ^ in dependencies.

httpx = { version = ">=0.23.3", optional = true }

[tool.poetry.group.dev.dependencies]
Expand Down