fix: 🐛 Several fixes in the ACI integration #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reasoning behind this? I didn't create the original ACI integration so I'm not sure why these strings were added to the DeviceRole slugs. |
…:chadell/nautobot-plugin-ssot into cisco-aci-remove-custom-slug-device-role
I'm using it, and I'm fixing some bugs, still not completed. |
chadell
changed the title
chadell
changed the title
chadell
commented
Sep 19, 2023
|
@jdrew82 it is ready for review |
Kircheneer
reviewed
Sep 19, 2023
Co-authored-by: Leo Kirchner <[email protected]>
|
@chadell Can we get the tests fixed on this? Looks good otherwise. |
jdrew82
added
the
status: action required
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.