Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPFabric Integration #212

Merged
merged 14 commits into from
Sep 29, 2023
Merged

Add IPFabric Integration #212

merged 14 commits into from
Sep 29, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Sep 15, 2023

Closes NaN

What's Changed

Added IPFabric integration from develop branch.

@jdrew82 jdrew82 added type: minor feature integration: ipfabric Issues/PRs for IPFabric integration labels Sep 20, 2023
@snaselj snaselj force-pushed the u/snaselj-ipfabric-next branch from 09481d3 to 1e3463e Compare September 25, 2023 09:56
@snaselj snaselj marked this pull request as ready for review September 25, 2023 09:57
@snaselj snaselj requested a review from a team as a code owner September 25, 2023 09:57
@snaselj
Copy link
Contributor Author

snaselj commented Sep 25, 2023

This PR is ready for review now. All IPFabric unittests are passing, however it needs to be tested manually.

@jdrew82

@pke11y
Copy link
Contributor

pke11y commented Sep 27, 2023

@alhogan can you help with the testing here?

@alhogan
Copy link
Contributor

alhogan commented Sep 27, 2023

@alhogan can you help with the testing here?

Absolutely, I will get this done today.

nautobot_ssot/__init__.py Outdated Show resolved Hide resolved
Update setting to have ipfabric prefix to follow pattern for integrations.
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit cbf8b0c into next-2.0 Sep 29, 2023
@jdrew82 jdrew82 deleted the u/snaselj-ipfabric-next branch September 29, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: ipfabric Issues/PRs for IPFabric integration type: minor feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants