Migrate PR #164 from Arista Child Repo #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
approved these changes
Sep 13, 2023
I've messaged him on the public slack as I don't have his email to co-author him. I'll update this once he responds. |
jdrew82
added
type: bug
|
@qduk any update on adding the co-author? |
Kircheneer
added
the
status: action required
|
@Kircheneer I've reached out to him and notified him of this PR. |
|
As we've attempted to give credit to @Eric-Jckson a few times for this PR and he's failed to respond I've added a comment into the code with reference to the original PR. Will merge this one tests are passing. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the PR from the child repo.