Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming work #130

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Renaming work #130

wants to merge 1 commit into from

Conversation

whitej6
Copy link
Contributor

@whitej6 whitej6 commented Dec 26, 2023

No description provided.

@whitej6 whitej6 requested a review from jeffkala as a code owner December 26, 2023 19:40
@itdependsnetworks
Copy link
Contributor

ok, I see now that it was worded as:

Nautobot Plugin Nornir is the only app that has plugin in the package name and will keep it's python package named nautobot_plugin_nornir

It wasn't clear that anything else was changing, need to think about this one.

@whitej6
Copy link
Contributor Author

whitej6 commented Dec 29, 2023

ok, I see now that it was worded as:

Nautobot Plugin Nornir is the only app that has plugin in the package name and will keep it's python package named nautobot_plugin_nornir

It wasn't clear that anything else was changing, need to think about this one.

Yeah I'd like to figure out long term to fully rename without causing breaking changes.

Copy link
Contributor

@jeffkala jeffkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with it. Would like a spot check from @itdependsnetworks as well.

@jeffkala
Copy link
Contributor

jeffkala commented Jan 2, 2024

Starting to feel like this will cause a lot of confusion if we don't do the project rename and the package rename at the same time. Gets confusing when reviewing the GC project rename and starting to keep straight the project names, the plugin_config section and what that should be named etc.

@itdependsnetworks
Copy link
Contributor

Yea, I am not sure about this, I think we need to change everything and have a proper rollout plan if we are going to go to this.

@itdependsnetworks
Copy link
Contributor

In talking with Jeff, will certainly have to think about this, so please remove this from the Jan 9th deadline. One potential migration plan would be

  • symlink the folder from app -> plugin
  • Allow either to be installed
  • Publish to pypi on both names
  • Once Nautobot Core goes to 3.0, we remove all reference to plugin.

This may allow us to support both app and plugin names for the time being.

@whitej6
Copy link
Contributor Author

whitej6 commented Jan 2, 2024

In talking with Jeff, will certainly have to think about this, so please remove this from the Jan 9th deadline. One potential migration plan would be

  • symlink the folder from app -> plugin
  • Allow either to be installed
  • Publish to pypi on both names
  • Once Nautobot Core goes to 3.0, we remove all reference to plugin.

This may allow us to support both app and plugin names for the time being.

Unfortunately I don't think the symlink would work due to import for the config has the match the config.name configured here

@itdependsnetworks
Copy link
Contributor

Good point... will have to think about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants