Replace sync_to_async with database_sync_to_async #356
+30
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Slack Socket Mode to properly close and reopen the database connection when finished processing a command.
Closes: #355
What's Changed
This PR introduces Channels.db.database_sync_to_async to resolve issue where the Asynchronous thread does not properly close and reopen database connections. This does not require adding Channels to the
INSTALLED_APPS
in nautobot_config.py, nor does it require replacing the uwsgi worker like the Channels installation page shows.To Do