Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slack-sdk dependency #335

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix slack-sdk dependency #335

merged 2 commits into from
Oct 9, 2024

Conversation

jjeff07
Copy link
Contributor

@jjeff07 jjeff07 commented Oct 3, 2024

Closes: #333

slack-sdk file_upload_V2 was introduced in https://github.com/slackapi/python-slack-sdk/releases/tag/v3.19.0

@glennmatthews
Copy link
Contributor

Why 3.19.0 in the PR if the feature wasn't introduced until 3.23?

@jjeff07
Copy link
Contributor Author

jjeff07 commented Oct 3, 2024

Why 3.19.0 in the PR if the feature wasn't introduced until 3.23?

Fixed description.

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smk4664 smk4664 merged commit f734707 into nautobot:develop Oct 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned slack-sdk requirement is wrong
3 participants