Add NSO integration #288
Merged
Add NSO integration #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanukes
requested review from
glennmatthews,
jvanderaa,
smk4664 and
whitej6
as code owners
|
Quick note to say that integration docs structure has been slightly changed by #265 (to align with the way it's done by SSoT), which will require a bit of an update in this PR and a rebase. |
smk4664
reviewed
Feb 26, 2024
romanukes
force-pushed
the
nso_integration
branch
from
fad0a5d to
2d2912d
Compare
romanukes
force-pushed
the
nso_integration
branch
from
4bb4626 to
651da37
Compare
smk4664
requested changes
Mar 13, 2024
There was a problem hiding this comment.
As discussed on call, we are going to try to replace this model with a config instead, so we do not add a required model in the database for an optional integration.
# Conflicts: # poetry.lock # pyproject.toml
smk4664
reviewed
Mar 18, 2024
| @@ -48,7 +49,7 @@ | |||
| with contextlib.suppress(ObjectDoesNotExist): | |||
| admin = User.objects.get(name="admin") | |||
| ChatOpsAccountLink.objects.update_or_create( | |||
| user_id="jactwicuqb8bu8pau8mgjydzeo", | |||
There was a problem hiding this comment.
To match the Mattermost SQL dump. Mattermost integration didn't work without this change
smk4664
approved these changes
Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: