Release 3.0.0 #279
Merged
Release 3.0.0 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v1.9.1
Prepare for Release v1.10.0
Release v1.11.0
Release v2.0.0
Release v2.0.2
Replace Device_role, ipam.Role with Role, and replace Region, Site with Location and Location Type.
These changes allow the app to load in alpha2.
Use Pre-Release version for testing Nautobot 2.0 support.
Release Candidate Prep
Fix access_grant_edit
Release 2.0.3
v3.0.0rc2
Match Python versions with Nautobot 2.0
Add NotesView to URLs.
smk4664
requested review from
glennmatthews,
jvanderaa and
whitej6
as code owners
HanlinMiao
reviewed
Sep 29, 2023
| @@ -1,7 +1,7 @@ | |||
| """Administrative capabilities for nautobot_chatops plugin.""" | |||
|
|
|||
| from django.contrib import admin | |||
| from .models import CommandLog | |||
| from .models import CommandLog, ChatOpsAccountLink | |||
There was a problem hiding this comment.
Suggested change
| from .models import CommandLog, ChatOpsAccountLink | |
| from .models import ChatOpsAccountLink, CommandLog |
| from nautobot_chatops.models import AccessGrant, CommandToken | ||
| from nautobot_chatops.filters import AccessGrantFilterSet, CommandTokenFilterSet | ||
| from nautobot_chatops.api.serializers import AccessGrantSerializer, CommandLogSerializer, CommandTokenSerializer | ||
| from nautobot_chatops.models import AccessGrant, CommandToken, CommandLog |
There was a problem hiding this comment.
Suggested change
| from nautobot_chatops.models import AccessGrant, CommandToken, CommandLog | |
| from nautobot_chatops.models import AccessGrant, CommandLog, CommandToken |
| @@ -15,15 +15,23 @@ def get_view_name(self): | |||
| return "Nautobot Chatops" | |||
|
|
|||
|
|
|||
| class CommandTokenViewSet(ModelViewSet): # pylint: disable=too-many-ancestors | |||
| class CommandTokenViewSet(NautobotModelViewSet): # pylint: disable=too-many-ancestors | |||
There was a problem hiding this comment.
Suggested change
| class CommandTokenViewSet(NautobotModelViewSet): # pylint: disable=too-many-ancestors | |
| class CommandTokenViewSet(NautobotModelViewSet): |
| filterset_class = CommandLogFilterSet | ||
|
|
||
|
|
||
| class AccessGrantViewSet(NautobotModelViewSet): # pylint: disable=too-many-ancestors |
There was a problem hiding this comment.
Suggested change
| class AccessGrantViewSet(NautobotModelViewSet): # pylint: disable=too-many-ancestors | |
| class AccessGrantViewSet(NautobotModelViewSet): |
|
|
||
|
|
||
| class AccessGrantListView(PermissionRequiredMixin, ObjectListView): | ||
| """View for listing all extant AccessGrants.""" | ||
|
|
||
| # Set the action buttons to correspond to what there are views. If import/export are added, this should be updated | ||
| action_buttons = ("add",) | ||
| permission_required = "nautobot_chatops.view_accessgrant" | ||
| permission_required = "nautobot_chatops.view_commandlog" |
There was a problem hiding this comment.
Is this change correct here? Seems like the old one is more correct.
| permission_required = "nautobot_chatops.view_commandlog" | ||
| http_method_names = ["get", "post"] | ||
| class CommandLogListView(PermissionRequiredMixin, ObjectListView): | ||
| """View for listing all extant AccessGrants.""" |
There was a problem hiding this comment.
Suggested change
| """View for listing all extant AccessGrants.""" | |
| """View for listing all extant Command Logs.""" |
|
|
||
| action_buttons = ("export",) | ||
| permission_required = "nautobot_chatops.view_accessgrant" |
There was a problem hiding this comment.
Suggested change
| permission_required = "nautobot_chatops.view_accessgrant" | |
| permission_required = "nautobot_chatops.view_commandlog" |
|
|
||
|
|
||
| class AccessGrantListView(PermissionRequiredMixin, ObjectListView): | ||
| """View for listing all extant AccessGrants.""" | ||
|
|
||
| # Set the action buttons to correspond to what there are views. If import/export are added, this should be updated | ||
| action_buttons = ("add",) | ||
| permission_required = "nautobot_chatops.view_accessgrant" | ||
| permission_required = "nautobot_chatops.view_commandlog" |
There was a problem hiding this comment.
Suggested change
| permission_required = "nautobot_chatops.view_commandlog" | |
| permission_required = "nautobot_chatops.view_accessgrant" |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Add support for Nautobot 2.0
Add ability to link Chat Platform User accounts to Nautobot User
TODO