-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User permissions #258
Merged
Merged
User permissions #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smk4664
requested review from
glennmatthews,
jvanderaa and
whitej6
as code owners
September 14, 2023 20:13
snaselj
reviewed
Sep 15, 2023
snaselj
reviewed
Sep 15, 2023
snaselj
reviewed
Sep 15, 2023
snaselj
reviewed
Sep 15, 2023
snaselj
reviewed
Sep 15, 2023
snaselj
reviewed
Sep 15, 2023
snaselj
reviewed
Sep 15, 2023
snaselj
reviewed
Sep 15, 2023
snaselj
reviewed
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions, with my limited knowledge LGTM
Great feaure 👍
Co-authored-by: Jan Snasel <[email protected]>
…-chatops into user_permissions
Co-authored-by: Jan Snasel <[email protected]>
…-chatops into user_permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #112
What's Changed
Adds a new feature to Link the Nautobot User with a Chat User. This allows more granular permissions for chat commands, as the Chat User will only see devices/racks/circuits/etc. that they have permissions to in Nautobot. This will open up new possibilities for Chat Commands, like running jobs, creating Notes, creating/updating records etc.
TODO