Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed extends base.html to extends generic/object_list.html for list templates #175

Merged
merged 8 commits into from
Feb 7, 2023

Conversation

briddo
Copy link
Contributor

@briddo briddo commented Jan 30, 2023

Closes: #174

What's Changed

Changed extends 'base.html' to extends 'generic/object_list.html' in list templates and removed unneeded loads from these templates.

@glennmatthews
Copy link
Contributor

How much of block content can now be removed after changing the base template?

Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @briddo

@smk4664 smk4664 merged commit 7054d18 into develop Feb 7, 2023
@smk4664 smk4664 mentioned this pull request Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy list templates need to be changed to extend generic/object_list.html
3 participants