Merge pull request #198 from MeganerdDev/patch-1

Improve visibility for access_key token exception in get_token()
nautobot · May 31, 2023 · 89385bc · 89385bc
2 parents ff4fab4 + d790829
commit 89385bc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/changes/197.added b/changes/197.added
@@ -0,0 +1 @@
+Add a try/except block and error logger message when access_token missing from get_token() response.
diff --git a/nautobot_chatops/dispatchers/ms_teams.py b/nautobot_chatops/dispatchers/ms_teams.py
@@ -63,7 +63,18 @@ def get_token():
             },
             timeout=15,
         )
-        token = response.json()["access_token"]
+        logger.debug("DEBUG: get_token() response %s", response.json())
+        try:
+            token = response.json()["access_token"]
+        except KeyError as exc:
+            logger.error(
+                "get_token() response is missing access_token, which indicates an error authenticating with MS Teams."
+                "Check the app_id and app_secret."
+            )
+            raise KeyError(
+                "get_token() response is missing access_token, which indicates an error authenticating with MS Teams."
+                "Check the app_id and app_secret."
+            ) from exc
         return token
 
     def _send(self, content, content_type="message"):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Add a try/except block and error logger message when access_token missing from get_token() response.