Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Checklist #144

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Add Release Checklist #144

merged 9 commits into from
Oct 10, 2024

Conversation

cmsirbu
Copy link
Contributor

@cmsirbu cmsirbu commented Aug 13, 2024

This PR documents, step by step, what a maintainer should do when cutting a new release for an open source App.

I have tested these changes successfully in the https://github.com/nautobot/nautobot-app-dev-example repo, with the exception of the LTM steps, due to a lack of an LTM branch in dev-example.

@cmsirbu cmsirbu requested review from smk4664 and gsnider2195 August 13, 2024 12:26
@cmsirbu cmsirbu added this to the v2.4.0 milestone Aug 13, 2024
@cmsirbu cmsirbu self-assigned this Aug 13, 2024
glennmatthews
glennmatthews previously approved these changes Aug 13, 2024
Comment on lines +164 to +171
First, sync your `main` branch with upstream changes: `git switch main && git pull`.

Create a new branch from `main` called `release-1.4.2-to-develop` and use `poetry version prepatch` to bump the development version to the next release.

For example, if you just released `v1.4.2`:

```no-highlight
> git switch -c release-1.4.2-to-develop main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future versions of this you can skip the git switch main && git pull and just create your branch off of the upstream branch:

git fetch
git switch -c release-1.4.2-to-develop origin/main

6. Add all the changes and `git commit -m "Release v1.2.3"`, then `git push`.
7. Open a new PR against `ltm-1.6`. Once CI is passing in the PR, `Create a merge commit` (don't squash!).
8. Create a New Release in GitHub - use the same steps documented [here](#create-a-new-release-in-github).
9. Open a separate PR against `develop` to synchronize all LTM release changelogs into the latest version of the docs for visibility.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to emphasize that we're only updating docs in develop

gsnider2195
gsnider2195 previously approved these changes Aug 22, 2024
@smk4664
Copy link
Contributor

smk4664 commented Aug 29, 2024

Just because I hit this today, the Update Documentation section should include a note about updating the Compatibility Matrix.

smk4664
smk4664 previously approved these changes Oct 7, 2024
Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Changes!

gsnider2195
gsnider2195 previously approved these changes Oct 7, 2024

### Create a New Release in GitHub

Draft a [new release](https://github.com/nautobot/nautobot-app-dev-example/releases/new) with the following parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want these 3 instances of nautobot-app-dev-example to be changed to {{ cookiecutter.project_slug }}?


```no-highlight
> poetry version
nautobot-dev-example 1.0.0-beta.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be {{ cookiecutter.app_slug }}?

@gsnider2195 gsnider2195 dismissed stale reviews from smk4664 and themself via 4cf0b7c October 10, 2024 15:09
@gsnider2195 gsnider2195 merged commit 85824d9 into develop Oct 10, 2024
2 checks passed
@gsnider2195 gsnider2195 deleted the cs-add-release-checklist branch October 10, 2024 15:11
@gsnider2195 gsnider2195 mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git complains about file ownership when running invoke generate-release-notes
4 participants