Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backtest start and end time validation assertion #2203

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

davidsblom
Copy link
Collaborator

Pull Request

Fix backtest start and end time validation assertion

When running a backtest with a streaming catalog, it can happen that the last batch of data contains just 2 ticks. If these 2 ticks have the same ts_init, then the validation fails.

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested?

Running a backtest

@cjdsellers cjdsellers merged commit 362ff32 into develop Jan 11, 2025
12 checks passed
@cjdsellers cjdsellers deleted the fix-validation branch January 11, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants