Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sandbox account initialization #1613

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

davidsblom
Copy link
Member

…ation

Pull Request

The account is initialized when creating a new SandboxExecutionClient. The account is needed in the strategy to set the leverage and determine if a margin or cash account is used.

Type of change

Delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How has this change been tested?

Locally using the sandbox with the bybit data feed.

@davidsblom davidsblom changed the title sandbox: initialize the account of the SimulatedExchange on initializ… WIP sandbox: initialize the account of the SimulatedExchange on initializ… Apr 27, 2024
@davidsblom davidsblom changed the title WIP sandbox: initialize the account of the SimulatedExchange on initializ… sandbox: initialize the account of the SimulatedExchange on initializ… Apr 27, 2024
@davidsblom davidsblom requested a review from cjdsellers April 27, 2024 13:59
@cjdsellers cjdsellers changed the title sandbox: initialize the account of the SimulatedExchange on initializ… Fix sandbox account initialization Apr 27, 2024
@cjdsellers cjdsellers merged commit 2e23d21 into nautechsystems:develop Apr 27, 2024
9 checks passed
@davidsblom davidsblom deleted the sandbox branch August 7, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants