Add parsable raw string representation of Money object #1612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Currently
to_str
function ofMoney
object returns a string representation of a number with an underscore. For example, we return10_000.00 USD
instead of more native10000.00 USD
(and easier to parse by other systems).This looks right in logging where its easier to see bigger numbers with this separator but poses a problem for parsing with Rust where we cannot deserialize it back to the
Money
type. A lot of thesefrom_dict
functions rely onserde_json
to convert it back to native Rust type, and they fail onMoney
type deserializationSo
to_raw_str
was created to represent this more parsing-friendly format and it was added acrossto_dict
method of instruments