Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Betfair bugfix: Reload cache as a dict of venue and client order ids #1608

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

imemo88
Copy link
Contributor

@imemo88 imemo88 commented Apr 24, 2024

Pull Request

Reload venue order and client order id cache correctly after a reconnection event. Please see #betfair (discord) where the issue highlighted a bit better

Type of change

[x] Bug fix

How has this change been tested?

In production

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2024

CLA assistant check
All committers have signed the CLA.

@cjdsellers
Copy link
Member

Hi @imemo88

Thanks so much for the fix!

Looks like we just have pre-commit failing so far. You can run pre-commit with:

make pre-commit

or

pre-commit run --all-files

You can also run the following to install the git hook to ensure it always runs on local commits too:

pre-commit install

It looks like some auto-formatting from black will occur, then you can push another commit.

@cjdsellers cjdsellers changed the title Betfair bugfix: Reload cache as a dict of venue and client order ids instead of str, int Betfair bugfix: Reload cache as a dict of venue and client order ids Apr 24, 2024
@cjdsellers cjdsellers merged commit 536d647 into nautechsystems:develop Apr 24, 2024
8 checks passed
@imemo88 imemo88 deleted the betfair_fixes branch April 24, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants