-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CFD and Commodity support for Interactive Brokers #1604
Conversation
…symbology for parsing Instrument/contract of Interactivebrokers Signed-off-by: D <[email protected]>
Hi @DracheShiki Thanks so much for this awesome contribution 🙏. Looks like we just have pre-commit failing so far. You can run pre-commit with:
or
You can also run the following to install the git hook to ensure it always runs on local commits too:
It looks like some auto-formatting from |
LGTM. |
oh i just pushed the old one back-up without pre-commit. |
Signed-off-by: DracheShiki <[email protected]>
For |
Signed-off-by: DracheShiki <[email protected]>
well, i just get confused for a while that everytime i added "#noqa: C901" then i excuted "pre-commit run --all-files", the "#noqa: C901" would get deleted by precommit...Anyway i pushed a version with "#noqa: C901" and without excuting "pre-commit run --all-files" again xD |
The reason it gets deleted is because it expects on the first (def) line, even if its multi-line def. |
Signed-off-by: DracheShiki <[email protected]>
Oh thanks…That is also out of my cognition. |
Signed-off-by: DracheShiki <[email protected]>
Pull Request
add CFD and Commodity support for Interactivebrokers;
fix the strict_symbology for parsing Instrument/contract of Interactivebrokers
Type of change
How has this change been tested?
Tested with "XAUUSD.IBCMDTY", "XAUUSD.IBCFD", "IBUS30.IBCFD", "TSLA.IBCFD", "EUD/USD.IBCFD" by live trading and historical data downloading.
a doc that "IBCFD" and "IBCMDTY" used as venue (mapping to "SMART") might be updated.
Although it works with no bugs as far as i tested it, the cfd.pyx and commodity.pyx may need to be refined.
Thanks @rsmb7z for advice.