Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from_str pyo3 method in identifier_for_python macro #1599

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Add from_str pyo3 method in identifier_for_python macro #1599

merged 1 commit into from
Apr 20, 2024

Conversation

filipmacek
Copy link
Member

Pull Request

  • added from_str static pyo3 function in identifier_for_python macro and added typings in nautilus_pyo3.pyi file

@filipmacek filipmacek added the rust Relating to the Rust core label Apr 20, 2024
@filipmacek filipmacek requested a review from cjdsellers April 20, 2024 13:15
@filipmacek filipmacek self-assigned this Apr 20, 2024
@filipmacek filipmacek force-pushed the identifiers-from-str-pyo3-method branch from 9b20912 to fcf74b0 Compare April 20, 2024 13:32
cjdsellers
cjdsellers approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@cjdsellers cjdsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this might be redundant with the constructor though?

@cjdsellers cjdsellers merged commit 30aff27 into develop Apr 20, 2024
9 checks passed
@cjdsellers cjdsellers deleted the identifiers-from-str-pyo3-method branch April 20, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdsellers cjdsellers cjdsellers approved these changes

Assignees

@filipmacek filipmacek

Labels
rust Relating to the Rust core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipmacek @cjdsellers