Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement event OrderCancelRejected in Rust #1402

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

filipmacek
Copy link
Member

Pull Request

  • finished event OrderCancelRejected in rust and exported in with pyo3 and tested on the python side

@filipmacek filipmacek added the rust Relating to the Rust core label Dec 9, 2023
@filipmacek filipmacek requested a review from cjdsellers December 9, 2023 10:45
@filipmacek filipmacek self-assigned this Dec 9, 2023
@filipmacek filipmacek force-pushed the order-cancel-rejected-rust branch from feef080 to 1141b8d Compare December 10, 2023 21:33
@filipmacek filipmacek marked this pull request as ready for review December 10, 2023 21:33
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5991cc6) 88.79% compared to head (5991cc6) 88.79%.
Report is 1 commits behind head on develop.

❗ Current head 5991cc6 differs from pull request most recent head 1141b8d. Consider uploading reports for the commit 1141b8d to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1402   +/-   ##
========================================
  Coverage    88.79%   88.79%           
========================================
  Files          224      224           
  Lines        28555    28555           
========================================
  Hits         25356    25356           
  Misses        3199     3199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjdsellers cjdsellers merged commit 1173782 into develop Dec 11, 2023
13 checks passed
@cjdsellers cjdsellers deleted the order-cancel-rejected-rust branch December 11, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Relating to the Rust core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants