Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass headers in websocket connection #1299

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Pass headers in websocket connection #1299

merged 6 commits into from
Oct 23, 2023

Conversation

twitu
Copy link
Collaborator

@twitu twitu commented Oct 23, 2023

Pull Request

Closes #1236

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

The existing websocket python api has changed slightly because it takes a configuration object. Python tests have been updated.

How has this change been tested?

Cargo test

@twitu twitu mentioned this pull request Oct 23, 2023
1 task
@cjdsellers cjdsellers changed the base branch from master to develop October 23, 2023 08:24
@cjdsellers
Copy link
Member

Many thanks @ruthvik125 and @twitu 🙏

@cjdsellers cjdsellers merged commit 773b9d7 into develop Oct 23, 2023
7 checks passed
@cjdsellers cjdsellers deleted the web_socket_headers branch October 23, 2023 11:19
ghill2 pushed a commit to ghill2/nautilus_trader that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocketClient.connect(): Ability to pass connection headers
3 participants