Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fills report #1289

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Conversation

r3k4mn14r
Copy link
Contributor

Pull Request

Added a fills report in the spirit of the orders and fills report that contains all individual order fill events. #1287

Type of change

  • New feature (non-breaking change which adds functionality)

How has this change been tested?

Added two unit tests matching the unit tests from the other reports.

cjdsellers and others added 4 commits July 31, 2023 11:54
See release notes.
See release notes.
See release notes.
@r3k4mn14r r3k4mn14r mentioned this pull request Oct 20, 2023
@cjdsellers
Copy link
Member

Hi @r3k4mn14r

Thanks for this contribution!

Looks like the pre-commit just needs to be run:

make pre-commit

or

pre-commit run --all-files

@cjdsellers cjdsellers merged commit 8232c5e into nautechsystems:develop Oct 20, 2023
@r3k4mn14r r3k4mn14r deleted the feat/fills-report branch October 21, 2023 14:09
ghill2 pushed a commit to ghill2/nautilus_trader that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants