Standardize Bybit base_url param naming

nautechsystems · Apr 7, 2024 · 2821c48 · 2821c48
1 parent 4cdb73d
commit 2821c48
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/examples/live/bybit/bybit_ema_cross.py b/examples/live/bybit/bybit_ema_cross.py
@@ -69,7 +69,7 @@
         "BYBIT": BybitDataClientConfig(
             api_key=None,  # 'BYBIT_API_KEY' env var
             api_secret=None,  # 'BYBIT_API_SECRET' env var
-            http_base_url=None,  # Override with custom endpoint
+            base_url_http=None,  # Override with custom endpoint
             instrument_provider=InstrumentProviderConfig(load_all=True),
             # product_types=[product_type],  # Will load all instruments
             testnet=False,  # If client uses the testnet

diff --git a/examples/live/bybit/bybit_ema_cross_bracket_algo.py b/examples/live/bybit/bybit_ema_cross_bracket_algo.py
@@ -73,7 +73,7 @@
         "BYBIT": BybitDataClientConfig(
             api_key=None,  # 'BYBIT_API_KEY' env var
             api_secret=None,  # 'BYBIT_API_SECRET' env var
-            http_base_url=None,  # Override with custom endpoint
+            base_url_http=None,  # Override with custom endpoint
             instrument_provider=InstrumentProviderConfig(load_all=True),
             # product_types=[product_type],  # Will load all instruments
             testnet=False,  # If client uses the testnet

diff --git a/examples/live/bybit/bybit_market_maker.py b/examples/live/bybit/bybit_market_maker.py
@@ -81,7 +81,7 @@
         "BYBIT": BybitDataClientConfig(
             api_key=None,  # 'BYBIT_API_KEY' env var
             api_secret=None,  # 'BYBIT_API_SECRET' env var
-            http_base_url=None,  # Override with custom endpoint
+            base_url_http=None,  # Override with custom endpoint
             instrument_provider=InstrumentProviderConfig(load_all=True),
             # product_types=[product_type],  # Will load all instruments
             testnet=False,  # If client uses the testnet

diff --git a/nautilus_trader/adapters/bybit/config.py b/nautilus_trader/adapters/bybit/config.py
@@ -42,7 +42,7 @@ class BybitDataClientConfig(LiveDataClientConfig, frozen=True):
     api_key: str | None = None
     api_secret: str | None = None
     product_types: list[BybitProductType] | None = None
-    http_base_url: str | None = None
+    base_url_http: str | None = None
     testnet: bool = False
 
 

diff --git a/nautilus_trader/adapters/bybit/factories.py b/nautilus_trader/adapters/bybit/factories.py
@@ -177,7 +177,7 @@ def create(  # type: ignore
             clock=clock,
             key=config.api_key,
             secret=config.api_secret,
-            base_url=config.http_base_url,
+            base_url=config.base_url_http,
             is_testnet=config.testnet,
         )
         provider = get_bybit_instrument_provider(