Skip to content

Commit

Permalink
drivers: media: pisp_be: Remove unused fields in struct pisp_be_config
Browse files Browse the repository at this point in the history
These fields should not be set by either the user or the kernel driver
so remove them. Replace them with padding bytes to maintain backward
compatibility with existing userland applications.

Signed-off-by: Naushir Patuck <[email protected]>
  • Loading branch information
naushir committed Jan 16, 2025
1 parent a73ecaf commit 1f41d24
Showing 1 changed file with 4 additions and 20 deletions.
24 changes: 4 additions & 20 deletions include/uapi/linux/media/raspberrypi/pisp_be_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -774,15 +774,8 @@ struct pisp_be_hog_buffer_config {
* @dirty_flags_extra: Extra dirty flags
*/
struct pisp_be_config {
/* I/O configuration: */
struct pisp_be_input_buffer_config input_buffer;
struct pisp_be_tdn_input_buffer_config tdn_input_buffer;
struct pisp_be_stitch_input_buffer_config stitch_input_buffer;
struct pisp_be_tdn_output_buffer_config tdn_output_buffer;
struct pisp_be_stitch_output_buffer_config stitch_output_buffer;
struct pisp_be_output_buffer_config
output_buffer[PISP_BACK_END_NUM_OUTPUTS];
struct pisp_be_hog_buffer_config hog_buffer;
/* For backward compatibility */
uint8_t pad0[112];
/* Processing configuration: */
struct pisp_be_global_config global;
struct pisp_image_format_config input_format;
Expand Down Expand Up @@ -823,17 +816,8 @@ struct pisp_be_config {
output_format[PISP_BACK_END_NUM_OUTPUTS];
struct pisp_be_hog_config hog;
struct pisp_be_axi_config axi;
/* Non-register fields: */
struct pisp_be_lsc_extra lsc_extra;
struct pisp_be_cac_extra cac_extra;
struct pisp_be_downscale_extra
downscale_extra[PISP_BACK_END_NUM_OUTPUTS];
struct pisp_be_resample_extra resample_extra[PISP_BACK_END_NUM_OUTPUTS];
struct pisp_be_crop_config crop;
struct pisp_image_format_config hog_format;
__u32 dirty_flags_bayer; /* these use pisp_be_bayer_enable */
__u32 dirty_flags_rgb; /* use pisp_be_rgb_enable */
__u32 dirty_flags_extra; /* these use pisp_be_dirty_t */
/* For backward compatibility */
uint8_t pad1[84];
} __attribute__((packed));

/**
Expand Down

0 comments on commit 1f41d24

Please sign in to comment.