Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read FC neurons #44

Merged
merged 22 commits into from
Aug 29, 2019
Merged

Read FC neurons #44

merged 22 commits into from
Aug 29, 2019

Conversation

alexanderbates
Copy link
Collaborator

  • read flycircuit neurons and get flycircuit neuron IDs
  • updates to README
  • Not sure how to solve error thrown by Rmd Check

@jefferis
Copy link
Collaborator

(just a note that I still have work to do on this branch ...)

alexanderbates and others added 17 commits August 29, 2019 01:00
@alexanderbates @jefferis
Update README.md
7cbc5de
@alexanderbates @jefferis
Update zzz.R
0dcd63f
@alexanderbates @jefferis
CMTK registration to FCWB space
499bbb2 
GJ mods:

* move registrations to a folder included in package
* inst/extdata (perhaps against convention) is ignored during package
  build because it is in .Rbuildignore. This was likely the reason for
  the issue with the location of registration files earlier
* remove duplicate registration file
* had both gzipped and plain text version
@alexanderbates @jefferis
Update .gitignore
85f2c86
@alexanderbates @jefferis
roxygenise
d18d21c
@alexanderbates @jefferis
Update .Rbuildignore
c5cc965
@alexanderbates @jefferis
Create NEWS.md
33b4f8f
@alexanderbates @jefferis
README:
99f80d7
@alexanderbates @jefferis
Switch to separate add_registrations function
74f8819 
* correct path
@jefferis
make Greg maintainer again
d530cf9
@jefferis
doc / crosss-ref fixes
2f3374a
@jefferis
Missing imports
58789ef
@jefferis
Clean up flycircuit_get_ids
79dba19 
* was missing some ids and making extra page requests
* dontrun example – it's very long if pkgdown tries to run it
@jefferis
Option to fetch additional info re neuron ids
11aba1f 
* and details of v1.0 v 1.2 ids
@jefferis
doc fixes for flycircuit_read_neurons
dfbb2bd 
* don't run long running example
@jefferis
Make xform optional in flycircuit_read_neurons
7060eab
@jefferis
rename functions: flycircuit_ -> fc_
9b699dc 
* this is the pattern in the rest of the package
s
@jefferis jefferis merged commit 9b699dc into master Aug 29, 2019
@jefferis
Copy link
Collaborator

NB I rebased to avoid the addition of a duplicate copy of one of the warping registrations.

@jefferis
Copy link
Collaborator

Also note additional fixes in 7b59db6 for fc_page

@jefferis
Copy link
Collaborator

and that flycircuit_* was renamed to fc_* to match the rest of the package. @alexanderbates if this rename is a problem, you can potentially handle this by making a deprecated function in catnat that calls the correct flycircuit function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderbates @jefferis