New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullptr dereference in mesh_map::readMap() and remove dependency on mesh_client #73

Merged

Cakem1x merged 2 commits into naturerobots:humble from JustusBraun:fix/mesh-map

Jan 13, 2025

Contributor

JustusBraun commented Jan 10, 2025

This pr fixes the following two bugs:

The MeshMap would dereference a null pointer if no map could be loaded.
The mesh_navigation package had an <exec_depend> tag on the removed mesh_client package which prevents rosdep from working due to an unresolved package.

JustusBraun added 2 commits

January 7, 2025 18:48


          Fix segv in mesh_map when no mesh_buffer could be loaded

ee4b9fc


          Remove <exec_depend> key on removed package mesh_client

eb06721

Cakem1x approved these changes

View reviewed changes

Member

Cakem1x left a comment

Great, thanks for the fixes! 👍

Cakem1x merged commit ea54926 into naturerobots:humble

1 check passed

JustusBraun deleted the fix/mesh-map branch

January 13, 2025 08:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet