Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: overflowing images in callout #1032

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix: overflowing images in callout #1032

merged 1 commit into from
Oct 8, 2024

Conversation

jasongao97
Copy link
Contributor

@jasongao97 jasongao97 commented Oct 8, 2024

Fix #1024

This bug has occurred #299, and while it was initially addressed in PR #432, the fix was later reverted due to a conflict with the newly introduced codesplit block. However, both issues have now been resolved in this PR.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for nature-of-code-2nd-edition ready!

Name Link
🔨 Latest commit 0a25414
🔍 Latest deploy log https://app.netlify.com/sites/nature-of-code-2nd-edition/deploys/67053c9836009c000888ada9
😎 Deploy Preview https://deploy-preview-1032--nature-of-code-2nd-edition.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jasongao97
Copy link
Contributor Author

As in deploy preview:

image

@shiffman
Copy link
Member

shiffman commented Oct 8, 2024

Looks great, thank you!!!

@shiffman shiffman merged commit 287528c into main Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exercise 8.6 Image Size
2 participants