-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dep updates #159
Dep updates #159
Conversation
Getting closer, now only node 4/5 builds are failing with:
|
bfba79a did not take. It may be that both |
@springmeyer @BergWerkGIS Looks like undefining the variable did the trick (build) |
\o/ @brianreavis thank you!! |
Kudos to @Brigadier1-9 over at creatale/node-dv#33 for the idea! |
Sweet, this being possible allows me to stop patching node for the c++11 builds I do (mapbox/node@96310b0). /cc @BergWerkGIS Merging now! |
Solves #157 by upgrading gdal from 2.0.1 -> 2.0.2 and proj from 4.8.0- -> 4.9.2
Before merging:
..\..\..\deps\libproj\proj\src\pj_strtod.c(79): fatal error C1021: invalid preprocessor command 'warning' [C:\projects\node-gdal\build\deps\libproj\libproj.vcxproj]