Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dep updates #159

Merged
merged 7 commits into from
Apr 6, 2016
Merged

Dep updates #159

merged 7 commits into from
Apr 6, 2016

Conversation

springmeyer
Copy link
Collaborator

Solves #157 by upgrading gdal from 2.0.1 -> 2.0.2 and proj from 4.8.0- -> 4.9.2

Before merging:

  • Fix windows build problem ..\..\..\deps\libproj\proj\src\pj_strtod.c(79): fatal error C1021: invalid preprocessor command 'warning' [C:\projects\node-gdal\build\deps\libproj\libproj.vcxproj]

@springmeyer
Copy link
Collaborator Author

Getting closer, now only node 4/5 builds are failing with:

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\typeinfo(38): error C2504: 'exception': base class undefined [C:\projects\node-gdal\build\deps\libgeos\libgeos.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\typeinfo(42): error C2614: 'std::bad_cast': illegal member initialization: 'exception' is not a base or member [C:\projects\node-gdal\build\deps\libgeos\libgeos.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\typeinfo(59): error C2504: 'exception': base class undefined [C:\projects\node-gdal\build\deps\libgeos\libgeos.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\typeinfo(63): error C2614: 'std::bad_typeid': illegal member initialization: 'exception' is not a base or member [C:\projects\node-gdal\build\deps\libgeos\libgeos.vcxproj]

@springmeyer
Copy link
Collaborator Author

bfba79a did not take. It may be that both _HAS_EXCEPTIONS=0 (inherited from node) and _HAS_EXCEPTIONS=1 are set and the latter is not respected. Or _HAS_EXCEPTIONS=1 is not set. It is taking > 2 hours until the jobs run/fail, so I think the ideal next step is for @BergWerkGIS to take the baton here and try debugging locally.

@brianreavis
Copy link
Member

@springmeyer @BergWerkGIS Looks like undefining the variable did the trick (build)

@springmeyer
Copy link
Collaborator Author

\o/ @brianreavis thank you!!

@brianreavis
Copy link
Member

Kudos to @Brigadier1-9 over at creatale/node-dv#33 for the idea!

@springmeyer
Copy link
Collaborator Author

Sweet, this being possible allows me to stop patching node for the c++11 builds I do (mapbox/node@96310b0). /cc @BergWerkGIS

Merging now!

@springmeyer springmeyer merged commit a717d61 into master Apr 6, 2016
@springmeyer springmeyer deleted the dep-updates branch April 6, 2016 21:17
@springmeyer springmeyer mentioned this pull request Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants