Fix multiple test upload failing #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read each of them one by one, insert them one by one. Seems slower, but we avoid having all the tests in memory.
natsukagami
force-pushed
the
fix-multiple-test-upload-86
branch
from
c0177b1 to
9e83525
Compare
natsukagami
force-pushed
the
fix-multiple-test-upload-86
branch
from
44e8039 to
e9a16f1
Compare
natsukagami
commented
May 17, 2023
Comment on lines
+268
to
+276
| if _, err := db.Exec( | ||
| "INSERT INTO tests(name, test_group_id, input, output) VALUES (?, ?, ?, ?)", | ||
| test.Name, | ||
| test.TestGroupID, | ||
| input, | ||
| output, | ||
| ); err != nil { | ||
| return errors.Wrapf(err, "inserting test `%s`", test.Name) | ||
| } |
There was a problem hiding this comment.
Note for future me: We upload tests one-by-one so that we don't have to store all the tests' content in memory at once. This helps with big test-sets that adds up to gigabytes of text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86. Depends on #91.