Merge pull request #366 from oncicaradupopovici/main

[FIXED] Prevent memory leak on subscription failure

stan_test.go

@@ -2815,6 +2815,10 @@ func TestSubTimeout(t *testing.T) {
 	if req.ClientID != clientName || req.Subject != "foo" || req.Inbox == "" {
 		t.Fatalf("Unexpected sub close request: %+v", req)
 	}
+
+	if len(scc.subMap) > 0 {
+		t.Fatal("Expected subMap to be empty")
+	}
 }
 
 func TestSubCloseError(t *testing.T) {

sub.go

@@ -253,6 +253,16 @@ func (sc *conn) subscribe(subject, qgroup string, cb MsgHandler, options ...Subs
 	sc.subMap[sub.inbox] = sub
 	sc.Unlock()
 
+	doClean := true
+	defer func() {
+		if doClean {
+			sc.Lock()
+			//Un-register subscription.
+			delete(sc.subMap, sub.inbox)
+			sc.Unlock()
+		}
+	}()
+
 	// Hold lock throughout.
 	sub.Lock()
 	defer sub.Unlock()
@@ -325,6 +335,9 @@ func (sc *conn) subscribe(subject, qgroup string, cb MsgHandler, options ...Subs
 	}
 	sub.ackInbox = r.AckInbox
 
+	// Prevent cleanup on exit.
+	doClean = false
+
 	return sub, nil
 }