Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] generate --mem-resolver performance in setups that have huge number of users #624

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Nov 13, 2023

[FIX] generate command has a generic processing engine but when generating anything but nkey configurations, it shouldn't look at the users as this could significantly degrate generation performance when that data is not needed.

…ating anything but nkey configurations, it shouldn't look at the users as this could significantly degrate generation performance when that data is not needed.
Copy link

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 98665d7 into main Nov 13, 2023
6 of 8 checks passed
@aricart aricart deleted the fix-generate-resolver branch November 13, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants