Ordered consumer recreate & mem_storage R1 #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
changed the title
Jarema
force-pushed
the
jarema/ordered-recreate-mem-r1
branch
from
01a6c38
to
fc82ec8
Compare
caspervonb
reviewed
Oct 3, 2022
| let last_sequence = Arc::new(AtomicU64::new(0)); | ||
| let consumer_sequence = Arc::new(AtomicU64::new(0)); | ||
| let (shutdown_tx, shutdown_rx) = tokio::sync::oneshot::channel(); | ||
| tokio::task::spawn({ |
There was a problem hiding this comment.
Does this have to run out of band?
There was a problem hiding this comment.
If consumer will be deleted on the server, client will get no messages, nor nothing will be additionaly polled.
So I'm afraid yes - we need this in a task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements nats-io/nats-architecture-and-design#162 (comment)