Direct get #636
Merged
Direct get #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
reviewed
Sep 12, 2022
async-nats/src/jetstream/stream.rs
Outdated
| Ok(response) | ||
| } | ||
|
|
||
| pub async fn direct_get_by_sequence(&self, sequence: u64) -> Result<Message, Error> { |
There was a problem hiding this comment.
Naming:
Suggested change
| pub async fn direct_get_by_sequence(&self, sequence: u64) -> Result<Message, Error> { | |
| pub async fn get_direct_message_by_sequence(&self, sequence: u64) -> Result<Message, Error> { |
async-nats/src/jetstream/stream.rs
Outdated
| } | ||
| Ok(response) | ||
| } | ||
| pub async fn direct_get_next_for_subject(&self, subject: String) -> Result<Message, Error> { |
There was a problem hiding this comment.
Mirrors raw message API
Suggested change
| pub async fn direct_get_next_for_subject(&self, subject: String) -> Result<Message, Error> { | |
| pub async fn get_next_direct_message_by_subject(&self, subject: String) -> Result<Message, Error> { |
There was a problem hiding this comment.
direct.get -> get_direct is fine. The difference in API is though, that direct supports also next, so message_by_subject is ambiguous enough, that user would have to read docs to be sure if its next or last.
There was a problem hiding this comment.
Completely qualify it? e.g get_next_direct_message_by_subject
There was a problem hiding this comment.
I don't like phrasing get....direct_message. It's not a direct message. The name comes from the fact it can be ... fetched from any replica set member. Direct message does not make sense. Its Directly getting a normal Stream Message.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.