Add custom request prefix option #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
commented
Aug 10, 2022
async-nats/src/options.rs
Outdated
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| pub fn inbox_prefix<T: ToString>(mut self, prefix: T) -> ConnectOptions { |
There was a problem hiding this comment.
@caspervonb for options, maybe it's the best interface to use?
Explicitly states it will convert to owned String and yet allows for using &str.
caspervonb
reviewed
Aug 10, 2022
async-nats/src/options.rs
Outdated
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| pub fn inbox_prefix<T: ToString>(mut self, prefix: T) -> ConnectOptions { |
There was a problem hiding this comment.
Bikeshedding:
Suggested change
| pub fn inbox_prefix<T: ToString>(mut self, prefix: T) -> ConnectOptions { | |
| pub fn inbox_with_prefix<T: ToString>(mut self, prefix: T) -> ConnectOptions { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #602
Signed-off-by: Tomasz Pietrek [email protected]