Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_last_raw_message_by_subject to Stream #584

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add get_last_raw_message_by_subject to Stream #584

merged 1 commit into from
Aug 4, 2022

Conversation

caspervonb
Copy link
Collaborator

No description provided.

@caspervonb caspervonb requested a review from Jarema August 1, 2022 12:06
@Jarema
Copy link
Member

Jarema commented Aug 3, 2022

One pending question: do we want to expose RawMessage to public API and users?

@caspervonb
Copy link
Collaborator Author

caspervonb commented Aug 4, 2022 •
edited
Loading

One pending question: do we want to expose RawMessage to public API and users?

I'd say yeah, they're not the same as Messages. Feels like conversion should be explicit.
Right now it is already exposed anyhow, so that's bike shedding for another day? it would be a breaking change anyway.

Jarema
Jarema approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree,

LGTM

Let's back to this before release.

@caspervonb caspervonb force-pushed the get-last-message-by-subject branch from f6caf52 to 5079e03 Compare August 4, 2022 11:52
@caspervonb caspervonb merged commit c5bd39c into main Aug 4, 2022
@caspervonb caspervonb deleted the get-last-message-by-subject branch August 4, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspervonb @Jarema