Add query_account to jetstream::Context
#528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
force-pushed
the
jetstream-account
branch
2 times, most recently
from
132358e
to
e2c365f
Compare
Jarema
reviewed
Jun 22, 2022
async-nats/src/jetstream/account.rs
Outdated
| #[derive(Debug, Default, Serialize, Deserialize, Clone, Copy, PartialEq, Eq)] | ||
| pub struct Limits { | ||
| /// Maximum memory for this account (-1 if no limit) | ||
| pub max_memory: i64, |
There was a problem hiding this comment.
Wouldn't it be more Rusty if we would map -1 to None?
Same for all those values.
There was a problem hiding this comment.
Wouldn't it be more Rusty if we would map -1 to None?
It would.
There was a problem hiding this comment.
Is that an agreement to change it to that 😄 ?
There was a problem hiding this comment.
Yeah I'll fix it up today along with documenting the rest of the fields, these were carried over from the old definition.
caspervonb
force-pushed
the
jetstream-account
branch
from
e2c365f
to
41298dc
Compare
This was referenced Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nats-io/nats-architecture-and-design#120