Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove recursive calls #448

Merged
merged 5 commits into from
May 21, 2022
Merged

remove recursive calls #448

merged 5 commits into from
May 21, 2022

Conversation

segfaultdoc
Copy link
Contributor

Fixes the issue mentioned here

@segfaultdoc segfaultdoc mentioned this pull request May 19, 2022
Closed
whistlinwilly
whistlinwilly approved these changes May 19, 2022
View reviewed changes
Copy link

@whistlinwilly whistlinwilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuck yes nice find and fix

caspervonb
caspervonb reviewed May 20, 2022
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and looks good! Will wait for Thomasz to have a look before merging.

Jarema
Jarema approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

LGTM.

@Jarema Jarema merged commit a7b156e into nats-io:main May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buffalu buffalu buffalu left review comments

@Jarema Jarema Jarema approved these changes

@whistlinwilly whistlinwilly whistlinwilly approved these changes

@caspervonb caspervonb Awaiting requested review from caspervonb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@segfaultdoc @caspervonb @whistlinwilly @Jarema @buffalu