Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client doesn't need to be mutable self #434

Merged
merged 3 commits into from
May 12, 2022
Merged

Client doesn't need to be mutable self #434

merged 3 commits into from
May 12, 2022

Conversation

caspervonb
Copy link
Collaborator

Supersedes #421

@caspervonb caspervonb requested a review from Jarema May 11, 2022 13:24
Jarema
Jarema approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevelr
Copy link
Contributor

stevelr commented May 11, 2022

there are a few more mut's that can be removed:
examples/pub.rs, examples/sub.rs, and in the doc comments in src/lib.rs
There are others but I ended up with a three-way merge with too many conflicts. I'll wait till this is merged and try again with a new PR.

@caspervonb caspervonb merged commit 9ce1ffa into nats-io:main May 12, 2022
@caspervonb caspervonb mentioned this pull request May 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caspervonb @stevelr @Jarema