Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle async server errors #397

Merged
merged 1 commit into from
May 4, 2022
Merged

Handle async server errors #397

merged 1 commit into from
May 4, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Apr 28, 2022

No description provided.

caspervonb
caspervonb reviewed Apr 28, 2022
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
@Jarema Jarema marked this pull request as ready for review April 28, 2022 16:28
@Jarema Jarema marked this pull request as draft April 30, 2022 20:23
caspervonb
caspervonb reviewed May 1, 2022
View reviewed changes
async-nats/src/tls.rs Outdated Show resolved Hide resolved
caspervonb
caspervonb reviewed May 1, 2022
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
caspervonb
caspervonb reviewed May 3, 2022
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
@Jarema Jarema force-pushed the jarema/async-errors branch 2 times, most recently from cfe9b06 to 7facf2e Compare May 4, 2022 10:59
@Jarema Jarema marked this pull request as ready for review May 4, 2022 11:11
caspervonb
caspervonb reviewed May 4, 2022
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

async-nats/src/tls.rs Show resolved Hide resolved
async-nats/tests/client_tests.rs Show resolved Hide resolved
async-nats/tests/client_tests.rs Show resolved Hide resolved
caspervonb
caspervonb approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (Please either squash this or clean up the linear history tho 😁)

@Jarema Jarema merged commit 69ba445 into main May 4, 2022
@Jarema Jarema deleted the jarema/async-errors branch May 4, 2022 19:12
@caspervonb caspervonb mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarema @caspervonb