Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsubscribe after #385

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Add unsubscribe after #385

merged 2 commits into from
Apr 26, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Apr 22, 2022

No description provided.

@Jarema Jarema requested a review from caspervonb April 22, 2022 12:21
caspervonb
caspervonb reviewed Apr 22, 2022
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
caspervonb
caspervonb reviewed Apr 22, 2022
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
@Jarema
Copy link
Member Author

Jarema commented Apr 22, 2022

@caspervonb we understood correctly. I just rushed it a little :).

@Jarema Jarema requested a review from caspervonb April 22, 2022 13:30
caspervonb
caspervonb reviewed Apr 23, 2022
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
async-nats/src/lib.rs Outdated Show resolved Hide resolved
caspervonb
caspervonb reviewed Apr 24, 2022
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
@Jarema
Copy link
Member Author

Jarema commented Apr 25, 2022

Moved counting to Subscription. Cleanup needed.

@Jarema Jarema marked this pull request as draft April 25, 2022 07:50
@Jarema Jarema requested a review from caspervonb April 25, 2022 11:26
@Jarema Jarema marked this pull request as ready for review April 25, 2022 11:26
caspervonb
caspervonb reviewed Apr 26, 2022
View reviewed changes
async-nats/src/lib.rs Outdated Show resolved Hide resolved
caspervonb
caspervonb approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

async-nats/src/lib.rs Outdated Show resolved Hide resolved
@Jarema Jarema force-pushed the jarema/make-unsub-graceful branch from a04e95b to 6000b39 Compare April 26, 2022 08:45
@Jarema Jarema force-pushed the jarema/make-unsub-graceful branch from 6000b39 to 63843e2 Compare April 26, 2022 08:46
@Jarema Jarema merged commit 6d82724 into main Apr 26, 2022
@Jarema Jarema deleted the jarema/make-unsub-graceful branch April 26, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarema @caspervonb