Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt discard policy according to server version #327

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Adapt discard policy according to server version #327

merged 2 commits into from
Feb 18, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Feb 16, 2022 •
edited
Loading

Partially implements nats-io/nats-architecture-and-design#94 (first bullet point)

caspervonb
caspervonb approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test would be preferable but we aren't setup for setting multiple versions of the server in CI at the moment.

lgtm.

@Jarema
Copy link
Member Author

Jarema commented Feb 18, 2022

thats a good point. Will add an issue to remind us about that while doing refactor.

@Jarema Jarema merged commit e208a9a into main Feb 18, 2022
@Jarema Jarema deleted the jarema/kv-updates branch February 18, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarema @caspervonb