Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close() hang after js.subscribe() is called #321

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Fix close() hang after js.subscribe() is called #321

merged 1 commit into from
Feb 10, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Feb 10, 2022

No description provided.

@Jarema Jarema requested a review from caspervonb February 10, 2022 12:13
caspervonb
caspervonb approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for tests!

LGTM

@Jarema Jarema merged commit db36688 into main Feb 10, 2022
@Jarema Jarema deleted the jarema/fix-js-subscribe-hang-on-close branch February 10, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarema @caspervonb