Add kv::watch_many functions #1364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
piotrpio
reviewed
Jan 21, 2025
async-nats/src/jetstream/kv/mod.rs
Outdated
| @@ -507,6 +507,41 @@ impl Store { | |||
| .await | |||
| } | |||
|
|
|||
| /// Creates a [futures::Stream] over [Entries][Entry] a given key in the bucket, which yields | |||
There was a problem hiding this comment.
Something seems to be missing here
| .stream | ||
| .create_consumer(super::consumer::push::OrderedConfig { | ||
| deliver_subject: self.stream.context.client.new_inbox(), | ||
| description: Some("kv watch consumer".to_string()), |
There was a problem hiding this comment.
Is this some kid of convention used across the clients? Because if not, I don;t think it's good we have that description from one client but not from others.
There was a problem hiding this comment.
Let's discuss this on the OSS call. I think we did, but we never made it into ADR.
However- this convention is used across the client, so it's consistent at least in the context of the PR.
Signed-off-by: Tomasz Pietrek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek [email protected]