Add check for max payload size when publishing messages #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
add-check-for-payload-size
branch
3 times, most recently
from
d62fe39
to
7ef8045
Compare
async-nats/src/client.rs
Outdated
| @@ -45,6 +45,14 @@ impl From<tokio::sync::mpsc::error::SendError<Command>> for PublishError { | |||
| } | |||
| } | |||
|
|
|||
| pub struct MaxPayloadExceeded(String); | |||
There was a problem hiding this comment.
This would work a bit better if it:
- Implemented
Debug,Display,Error - Had fields for the length of the body and the max payload size, with the string formatting done in the
Displayimplementation
There was a problem hiding this comment.
I did it just to have an error in Draft.
Sure, your improvement is better, but that still makes this single error inconsistent with other errors, which have ErrorKind.
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
force-pushed
the
add-check-for-payload-size
branch
from
fd3a713
to
292f317
Compare
|
@paolobarbolini Decided to switch to how all the others errors are handled, as it's hardly breaking anyone with current not very useful struct. |
Jarema
requested review from
paolobarbolini,
neilalexander,
piotrpio and
autodidaddict
and removed request for
paolobarbolini
caspervonb
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds check if the messages Client is publishing to a server it is connected too does not exceed
max_payload.This unfortunately asks for changing the error from a simple struct that maps error from
mpscerror to a new one.Tests of how disruptive the error change is is under progress, hence the Draft.
We are using new
Atomicinstead of relying on the server info watcher for performance reasons.Signed-off-by: Tomasz Pietrek [email protected]