Add revision to kv operations #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
requested changes
Jan 2, 2024
Jarema
force-pushed
the
add-revision-to-kv-operations
branch
from
ec08134
to
fb6d9e2
Compare
Jarema
force-pushed
the
add-revision-to-kv-operations
branch
from
fb6d9e2
to
e5d2a86
Compare
Jarema
requested changes
Jan 3, 2024
Co-authored-by: Tomasz Pietrek <[email protected]>
Jarema
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the nats.net.v2 client, an option to add the expected revision was added. A delete or purge will be rejected similar to the update function.
This is needed to make better use of the immediately consistent properties of the kv store.
This is a breaking change, as all references to current deletes or purges will have to be updated to include a None.