Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rustls to v0.22 and related dependencies #1170

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Update rustls to v0.22 and related dependencies #1170

merged 1 commit into from
Dec 17, 2023

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Dec 3, 2023 •
edited
Loading

Still remaining to do:

  • Wait for rustls release v0.22.0
  • Wait for rustls-webpki release v0.102.0
  • Wait for rustls-pemfile release v2.0.0
  • Wait for tokio-rustls release v0.25.0
  • Wait for rustls-native-certs release v0.7.0
  • Upgrade all of the above dependencies once they're out
  • Test it

@paolobarbolini paolobarbolini force-pushed the rustls-0.22 branch 6 times, most recently from 27b3c1d to 238cf40 Compare December 5, 2023 11:27
@paolobarbolini paolobarbolini marked this pull request as ready for review December 7, 2023 21:13
@paolobarbolini
Copy link
Contributor Author

paolobarbolini commented Dec 7, 2023 •
edited
Loading

I've run this in production for the entire day and everything is working fine.
I've decided to remove the point about exposing the crypto provider option as I'm not currently interested in FIPS and it should probably make sense to figure out what other providers might be useful for use-cases like #1163 and implement it in a separate PR.

@Jarema Jarema self-requested a review December 17, 2023 14:01
Jarema
Jarema approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As always, thanks Paolo for your contribution ;).

@Jarema Jarema merged commit d5d9993 into nats-io:main Dec 17, 2023
11 checks passed
@Jarema Jarema mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolobarbolini @Jarema