Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Bump Typescript target to Node 14 (ES2020) #641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ginden
Copy link

@Ginden Ginden commented Nov 5, 2024

This change:

  • Improves performance (native async/await is faster than __awaiter)
  • Improves debugging (error stacktraces are preserved through async/await)
  • Reduces bundle size a bit (no var __awaiter in generated code)

This should be a safe change, as Node 14 is already required.

@aricart
Copy link
Member

aricart commented Dec 5, 2024

@Ginden the current in dev version bumps it to esnext - also the min requirement for the runtime is currently Node 18.

https://github.com/nats-io/nats.js/blob/cd48c792668af0de6689b104a5efce2dbe5841a4/transport-node/tsconfig.json#L3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants