Fix date time serialization to use ISO8601 #664
Conversation
| if (input.Offset == TimeSpan.Zero) | ||
| { | ||
| // This will make it place `Z` instead of `+00:00` at the end | ||
| result = Utf8Formatter.TryFormat(input.UtcDateTime, span, out written, new StandardFormat('O')); |
There was a problem hiding this comment.
Serialization is a hot path, so it's worth noting one thing here...
SharpLab seems to show better ASM for a readonly prop being referenced vs new even for simple case
Looks like Ctor can throw which may prevent some inlining However for all of this pedanticism, it may or may not get handled by PGO when it's actually run. Might be worth trying to run a microbench between the two, while also noting 'real' implementation of a readonly based on gist could be static (alas, Sharplab can't do statics easily) and likely could provide additional optimizations/benefits.
I'm guessing not many if anyone is using this feature i.e. passing so I'm seeing this as a bug fix and although it might break some installations I'm assuming nobody is really using this hence it's not worth the effort and confusion trying to create compatibility. But I might be wrong - I am at least 4-5 times a day 😅 |
|
Looks good, it appears that the ISO8601 format used also overlaps rfc3339 which is beneficial interop with other languages too |
* Add OnSocketAvailableAsync Hook (#647) * Refactor exception handling in NatsException (#677) * Fixed an exception which happens when PutAsync is used more than once and activity logging is enabled in main project (#675) * open Header.Writer class and create GetBytesLength method (#674) * Fix date time serialization to use ISO8601 (#664)
* Add OnSocketAvailableAsync Hook (#647) * Refactor exception handling in NatsException (#677) * Fixed an exception which happens when PutAsync is used more than once and activity logging is enabled in main project (#675) * open Header.Writer class and create GetBytesLength method (#674) * Fix date time serialization to use ISO8601 (#664)
Doesn't make sense to serialize datetime types with the default culture dependent formatting since it might differ between different platforms. with this PR we use ISO8601 formatting as indicated by
Oto maximize the compatibility among different platforms and languages.