Fix KV allow direct #879
Merged
Fix KV allow direct #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtmk
reviewed
Mar 15, 2024
|
|
||
| Assert.NotNull(kv1.Get(key1)); | ||
| Assert.NotNull(kv1.Get(key2)); | ||
| // TODO COME BACK ONCE SERVER IS FIXED |
There was a problem hiding this comment.
can we reference what the issue is?
There was a problem hiding this comment.
Yeah, if one is made.
mtmk
approved these changes
Mar 15, 2024
mtmk
approved these changes
Mar 18, 2024
mtmk
suggested changes
Mar 18, 2024
| @@ -47,7 +47,15 @@ private void Init(Msg msg, bool fromDirect, string streamName) | |||
| Headers = msg.Header; | |||
| Subject = msg.Header.GetLast(JetStreamConstants.NatsSubject); | |||
| Data = msg.Data; | |||
| Sequence = ulong.Parse(msg.Header[JetStreamConstants.NatsSequence]); | |||
| try | |||
There was a problem hiding this comment.
Multiple values in the header.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KV streams require allow_direct set to true. This setting was not done and now is fixed.