Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pending limits in the Options #844

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

LaurensVergote
Copy link
Contributor

Had a use case where I wanted to configure these on a connection-based level and noticed these options were not exposed yet.
In theory, Options.SubChannelLength can be obsoleted now, but might want to keep it for backwards compatibility

Copy link
Collaborator

@sixlettervariables sixlettervariables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider an obsolete attribute on the old property if it now unused. I think the move from int32 to int64 is fine, but would be helped by that note.

@LaurensVergote
Copy link
Contributor Author

Consider an obsolete attribute on the old property if it now unused. I think the move from int32 to int64 is fine, but would be helped by that note.

Marked as obsolete

@scottf scottf merged commit eddd4d6 into nats-io:main Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants